Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom amp optimizer and skip validation mode #10705

Merged
merged 14 commits into from Mar 24, 2020
Merged

Add custom amp optimizer and skip validation mode #10705

merged 14 commits into from Mar 24, 2020

Conversation

yosuke-furukawa
Copy link
Contributor

This PR could pass options to ampproject/toolbox-optimizer.

amp optimizer has some options to improve rendering, if this PR is merged, our web apps could use some options like Blurry Images Placeholders, Self Hosted Amp.

@ijjk
Copy link
Member

ijjk commented Feb 26, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 9.5s 10s ⚠️ +498ms
nodeModulesSize 56.2 MB 56.2 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 4.98 kB 4.98 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
index.html gzip 927 B 927 B ✓
link.html gzip 933 B 933 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 10.8s 10.7s -65ms
nodeModulesSize 56.2 MB 56.2 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 4.98 kB 4.98 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_error.js gzip 289 kB 289 kB ⚠️ +35 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 964 B 964 B ✓
index.js gzip 290 kB 290 kB -314 B
link.js gzip 298 kB 299 kB ⚠️ +1.14 kB
routerDirect.js gzip 298 kB 297 kB -1.17 kB
withRouter.js gzip 296 kB 297 kB ⚠️ +617 B
Overall change 1.47 MB 1.47 MB ⚠️ +302 B

Commit: 93eca3e

@ijjk
Copy link
Member

ijjk commented Mar 2, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 9.8s 9.8s -39ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.41 kB 5.41 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55 kB 55 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.44 kB 4.44 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51 kB 51 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
index.html gzip 925 B 925 B ✓
link.html gzip 935 B 935 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 10.9s 10.9s ⚠️ +56ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.41 kB 5.41 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55 kB 55 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.44 kB 4.44 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51 kB 51 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_error.js gzip 292 kB 292 kB ⚠️ +115 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 964 B 964 B ✓
index.js gzip 292 kB 292 kB -438 B
link.js gzip 300 kB 299 kB -620 B
routerDirect.js gzip 299 kB 298 kB -1.1 kB
withRouter.js gzip 298 kB 298 kB ⚠️ +15 B
Overall change 1.48 MB 1.48 MB -2.03 kB

Commit: e14c06e

@ijjk
Copy link
Member

ijjk commented Mar 3, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 7.4s 7.7s ⚠️ +324ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.76 kB 5.76 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..67cb.js gzip 9.69 kB 9.69 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.3 kB 55.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.64 kB 6.64 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.3 kB 51.3 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
index.html gzip 936 B 936 B ✓
link.html gzip 946 B 946 B ✓
withRouter.html gzip 934 B 934 B ✓
Overall change 2.82 kB 2.82 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 7.8s 8.1s ⚠️ +267ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.76 kB 5.76 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..67cb.js gzip 9.69 kB 9.69 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.3 kB 55.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.64 kB 6.64 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.3 kB 51.3 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_error.js gzip 292 kB 292 kB ⚠️ +590 B
404.html gzip 1.34 kB 1.34 kB ✓
hooks.html gzip 975 B 975 B ✓
index.js gzip 292 kB 292 kB -337 B
link.js gzip 300 kB 300 kB ⚠️ +24 B
routerDirect.js gzip 298 kB 298 kB ⚠️ +471 B
withRouter.js gzip 298 kB 299 kB ⚠️ +1.17 kB
Overall change 1.48 MB 1.48 MB ⚠️ +1.91 kB

@ijjk
Copy link
Member

ijjk commented Mar 4, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 7.6s 7.7s ⚠️ +132ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.76 kB 5.76 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..67cb.js gzip 9.69 kB 9.69 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.3 kB 55.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.64 kB 6.64 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.3 kB 51.3 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
index.html gzip 936 B 936 B ✓
link.html gzip 946 B 946 B ✓
withRouter.html gzip 934 B 934 B ✓
Overall change 2.82 kB 2.82 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 8.4s 8.5s ⚠️ +130ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.76 kB 5.76 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..67cb.js gzip 9.69 kB 9.69 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.3 kB 55.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.64 kB 6.64 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.3 kB 51.3 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_error.js gzip 292 kB 292 kB ⚠️ +25 B
404.html gzip 1.34 kB 1.34 kB ✓
hooks.html gzip 975 B 975 B ✓
index.js gzip 293 kB 292 kB -1.07 kB
link.js gzip 299 kB 299 kB ⚠️ +48 B
routerDirect.js gzip 298 kB 298 kB -269 B
withRouter.js gzip 298 kB 298 kB ⚠️ +91 B
Overall change 1.48 MB 1.48 MB -1.17 kB

@ijjk
Copy link
Member

ijjk commented Mar 4, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 10.3s 10.4s ⚠️ +63ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.76 kB 5.76 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..67cb.js gzip 9.69 kB 9.69 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.3 kB 55.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.64 kB 6.64 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.3 kB 51.3 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
index.html gzip 936 B 936 B ✓
link.html gzip 946 B 946 B ✓
withRouter.html gzip 934 B 934 B ✓
Overall change 2.82 kB 2.82 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 11.2s 11.3s ⚠️ +82ms
nodeModulesSize 56.3 MB 56.3 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.76 kB 5.76 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..67cb.js gzip 9.69 kB 9.69 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.3 kB 55.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.64 kB 6.64 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.3 kB 51.3 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_error.js gzip 292 kB 292 kB -557 B
404.html gzip 1.34 kB 1.34 kB ✓
hooks.html gzip 975 B 975 B ✓
index.js gzip 293 kB 292 kB -710 B
link.js gzip 300 kB 300 kB ⚠️ +450 B
routerDirect.js gzip 299 kB 298 kB -1.18 kB
withRouter.js gzip 298 kB 298 kB -403 B
Overall change 1.48 MB 1.48 MB -2.4 kB

@ijjk
Copy link
Member

ijjk commented Mar 9, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 9.5s 9.6s ⚠️ +65ms
nodeModulesSize 56.5 MB 56.5 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
index.html gzip 915 B 915 B ✓
link.html gzip 924 B 924 B ✓
withRouter.html gzip 910 B 910 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 10.2s 10.2s ⚠️ +33ms
nodeModulesSize 56.5 MB 56.5 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_error.js gzip 292 kB 293 kB ⚠️ +946 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 955 B 955 B ✓
index.js gzip 292 kB 292 kB ⚠️ +554 B
link.js gzip 300 kB 300 kB -83 B
routerDirect.js gzip 298 kB 298 kB ⚠️ +304 B
withRouter.js gzip 298 kB 299 kB ⚠️ +806 B
Overall change 1.48 MB 1.49 MB ⚠️ +2.53 kB

@ijjk
Copy link
Member

ijjk commented Mar 9, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 9.5s 9.7s ⚠️ +145ms
nodeModulesSize 56.5 MB 56.5 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
index.html gzip 917 B 917 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 914 B 914 B ✓
Overall change 2.76 kB 2.76 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 10.4s 10.6s ⚠️ +263ms
nodeModulesSize 56.5 MB 56.5 MB ⚠️ +1.86 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_error.js gzip 293 kB 292 kB -1.1 kB
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 958 B 958 B ✓
index.js gzip 292 kB 292 kB ⚠️ +169 B
link.js gzip 300 kB 300 kB -292 B
routerDirect.js gzip 298 kB 298 kB ⚠️ +194 B
withRouter.js gzip 298 kB 298 kB ⚠️ +27 B
Overall change 1.48 MB 1.48 MB -1 kB

@yosuke-furukawa
Copy link
Contributor Author

Could someone review this PR?

@ijjk
Copy link
Member

ijjk commented Mar 10, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 9.3s 9.3s -7ms
nodeModulesSize 56.5 MB 56.5 MB ⚠️ +2.99 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
index.html gzip 916 B 916 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 914 B 914 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 10.1s 10.2s ⚠️ +62ms
nodeModulesSize 56.5 MB 56.5 MB ⚠️ +2.99 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_error.js gzip 293 kB 293 kB -306 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 293 kB 293 kB ⚠️ +293 B
link.js gzip 301 kB 301 kB ⚠️ +69 B
routerDirect.js gzip 300 kB 299 kB -753 B
withRouter.js gzip 299 kB 299 kB ⚠️ +228 B
Overall change 1.49 MB 1.49 MB -469 B

@ijjk
Copy link
Member

ijjk commented Mar 10, 2020 •
edited

Failing test suites

test/integration/serverless/test/index.test.js

  • Serverless > should have correct canonical link
  • Serverless > should have correct canonical link (auto-export link)
Expand output

● Serverless › should have correct canonical link

expect(received).toMatch(expected)

Expected pattern: /rel="canonical" href="\/some-amp"/
Received string:  "<!DOCTYPE html><html amp i-amphtml-layout i-amphtml-no-boilerplate transformed=\"self;v=1\"><head><meta charset=\"utf-8\"><style amp-runtime i-amphtml-version=\"012002251816300\">html{overflow-x:hidden!important}html.i-amphtml-fie{height:100%!important;width:100%!important}html:not([amp4ads]),html:not([amp4ads]) body{height:auto!important}html:not([amp4ads]) body{margin:0!important}body{-webkit-text-size-adjust:100%;-moz-text-size-adjust:100%;-ms-text-size-adjust:100%;text-size-adjust:100%}html.i-amphtml-singledoc.i-amphtml-embedded{-ms-touch-action:pan-y;touch-action:pan-y}html.i-amphtml-fie>body,html.i-amphtml-singledoc>body{overflow:visible!important}html.i-amphtml-fie:not(.i-amphtml-inabox)>body,html.i-amphtml-singledoc:not(.i-amphtml-inabox)>body{position:relative!important}html.i-amphtml-webview>body{overflow-x:hidden!important;overflow-y:visible!important;min-height:100vh!important}html.i-amphtml-ios-embed-legacy>body{overflow-x:hidden!important;overflow-y:auto!important;position:absolute!important}html.i-amphtml-ios-embed{overflow-y:auto!important;position:static}#i-amphtml-wrapper{overflow-x:hidden!important;overflow-y:auto!important;position:absolute!important;top:0!important;left:0!important;right:0!important;bottom:0!important;margin:0!important;display:block!important}html.i-amphtml-ios-embed.i-amphtml-ios-overscroll,html.i-amphtml-ios-embed.i-amphtml-ios-overscroll>#i-amphtml-wrapper{-webkit-overflow-scrolling:touch!important}#i-amphtml-wrapper>body{position:relative!important;border-top:1px solid transparent!important}#i-amphtml-wrapper+body{visibility:visible}#i-amphtml-wrapper+body .i-amphtml-lightbox-element,#i-amphtml-wrapper+body[i-amphtml-lightbox]{visibility:hidden}#i-amphtml-wrapper+body[i-amphtml-lightbox] .i-amphtml-lightbox-element{visibility:visible}#i-amphtml-wrapper.i-amphtml-scroll-disabled,.i-amphtml-scroll-disabled{overflow-x:hidden!important;overflow-y:hidden!important}amp-instagram{padding:54px 0px 0px!important;background-color:#fff}amp-iframe iframe{box-sizing:border-box!important}[amp-access][amp-access-hide]{display:none}[subscriptions-dialog],body:not(.i-amphtml-subs-ready) [subscriptions-action],body:not(.i-amphtml-subs-ready) [subscriptions-section]{display:none!important}amp-experiment,amp-live-list>[update],amp-share-tracking{display:none}.i-amphtml-jank-meter{position:fixed;background-color:rgba(232,72,95,0.5);bottom:0;right:0;color:#fff;font-size:16px;z-index:1000;padding:5px}amp-list[resizable-children]>.i-amphtml-loading-container.amp-hidden{display:none!important}amp-list[load-more] [load-more-button],amp-list[load-more] [load-more-end],amp-list[load-more] [load-more-failed],amp-list[load-more] [load-more-loading]{display:none}amp-story-page,amp-story[standalone]{min-height:1px!important;display:block!important;height:100%!important;margin:0!important;padding:0!important;overflow:hidden!important;width:100%!important}amp-story[standalone]{background-color:#202125!important;position:relative!important}amp-story-page{background-color:#757575}amp-story .amp-active>div{display:none!important}amp-story-page:not(:first-of-type):not([distance]):not([active]){transform:translateY(1000vh)!important}amp-autocomplete{position:relative!important;display:inline-block!important}amp-autocomplete>input,amp-autocomplete>textarea{padding:0.5rem;border:1px solid rgba(0,0,0,0.33)}.i-amphtml-autocomplete-results,amp-autocomplete>input,amp-autocomplete>textarea{font-size:1rem;line-height:1.5rem}[amp-fx^=fly-in]{visibility:hidden}
/*# sourceURL=/css/ampdoc.css*/[hidden]{display:none!important}.i-amphtml-element{display:inline-block}.i-amphtml-blurry-placeholder{transition:opacity 0.3s cubic-bezier(0.0,0.0,0.2,1)!important}[layout=nodisplay]:not(.i-amphtml-element){display:none!important}.i-amphtml-layout-fixed,[layout=fixed][width][height]:not(.i-amphtml-layout-fixed){display:inline-block;position:relative}.i-amphtml-layout-responsive,[layout=responsive][width][height]:not(.i-amphtml-layout-responsive),[width][height][sizes]:not(.i-amphtml-layout-responsive){display:block;position:relative}.i-amphtml-layout-intrinsic{display:inline-block;position:relative;max-width:100%}.i-amphtml-intrinsic-sizer{max-width:100%;display:block!important}.i-amphtml-layout-container,.i-amphtml-layout-fixed-height,[layout=container],[layout=fixed-height][height]{display:block;position:relative}.i-amphtml-layout-fill,[layout=fill]:not(.i-amphtml-layout-fill){display:block;overflow:hidden!important;position:absolute;top:0;left:0;bottom:0;right:0}.i-amphtml-layout-flex-item,[layout=flex-item]:not(.i-amphtml-layout-flex-item){display:block;position:relative;-ms-flex:1 1 auto;flex:1 1 auto}.i-amphtml-layout-fluid{position:relative}.i-amphtml-layout-size-defined{overflow:hidden!important}.i-amphtml-layout-awaiting-size{position:absolute!important;top:auto!important;bottom:auto!important}i-amphtml-sizer{display:block!important}.i-amphtml-blurry-placeholder,.i-amphtml-fill-content{display:block;height:0;max-height:100%;max-width:100%;min-height:100%;min-width:100%;width:0;margin:auto}.i-amphtml-layout-size-defined .i-amphtml-fill-content{position:absolute;top:0;left:0;bottom:0;right:0}.i-amphtml-layout-intrinsic .i-amphtml-sizer{max-width:100%}.i-amphtml-replaced-content,.i-amphtml-screen-reader{padding:0!important;border:none!important}.i-amphtml-screen-reader{position:fixed!important;top:0px!important;left:0px!important;width:4px!important;height:4px!important;opacity:0!important;overflow:hidden!important;margin:0!important;display:block!important;visibility:visible!important}.i-amphtml-screen-reader~.i-amphtml-screen-reader{left:8px!important}.i-amphtml-screen-reader~.i-amphtml-screen-reader~.i-amphtml-screen-reader{left:12px!important}.i-amphtml-screen-reader~.i-amphtml-screen-reader~.i-amphtml-screen-reader~.i-amphtml-screen-reader{left:16px!important}.i-amphtml-unresolved{position:relative;overflow:hidden!important}.i-amphtml-select-disabled{-webkit-user-select:none!important;-moz-user-select:none!important;-ms-user-select:none!important;user-select:none!important}.i-amphtml-notbuilt,[layout]:not(.i-amphtml-element){position:relative;overflow:hidden!important;color:transparent!important}.i-amphtml-notbuilt:not(.i-amphtml-layout-container)>*,[layout]:not([layout=container]):not(.i-amphtml-element)>*{display:none}.i-amphtml-ghost{visibility:hidden!important}.i-amphtml-element>[placeholder],[layout]:not(.i-amphtml-element)>[placeholder]{display:block}.i-amphtml-element>[placeholder].amp-hidden,.i-amphtml-element>[placeholder].hidden{visibility:hidden}.i-amphtml-element:not(.amp-notsupported)>[fallback],.i-amphtml-layout-container>[placeholder].amp-hidden,.i-amphtml-layout-container>[placeholder].hidden{display:none}.i-amphtml-layout-size-defined>[fallback],.i-amphtml-layout-size-defined>[placeholder]{position:absolute!important;top:0!important;left:0!important;right:0!important;bottom:0!important;z-index:1}.i-amphtml-notbuilt>[placeholder]{display:block!important}.i-amphtml-hidden-by-media-query{display:none!important}.i-amphtml-element-error{background:red!important;color:#fff!important;position:relative!important}.i-amphtml-element-error:before{content:attr(error-message)}i-amp-scroll-container,i-amphtml-scroll-container{position:absolute;top:0;left:0;right:0;bottom:0;display:block}i-amp-scroll-container.amp-active,i-amphtml-scroll-container.amp-active{overflow:auto;-webkit-overflow-scrolling:touch}.i-amphtml-loading-container{display:block!important;pointer-events:none;z-index:1}.i-amphtml-notbuilt>.i-amphtml-loading-container{display:block!important}.i-amphtml-loading-container.amp-hidden{visibility:hidden}.i-amphtml-element>[overflow]{cursor:pointer;position:relative;z-index:2;visibility:hidden}.i-amphtml-element>[overflow].amp-visible{visibility:visible}template{display:none!important}.amp-border-box,.amp-border-box *,.amp-border-box :after,.amp-border-box :before{box-sizing:border-box}amp-pixel{display:none!important}amp-analytics,amp-story-auto-ads{position:fixed!important;top:0!important;width:1px!important;height:1px!important;overflow:hidden!important;visibility:hidden}html.i-amphtml-fie>amp-analytics{position:initial!important}[visible-when-invalid]:not(.visible),amp-list [fetch-error],form [submit-error],form [submit-success],form [submitting]{display:none}amp-accordion{display:block!important}amp-accordion>section{float:none!important}amp-accordion>section>*{float:none!important;display:block!important;overflow:hidden!important;position:relative!important}amp-accordion,amp-accordion>section{margin:0}amp-accordion>section>:last-child{display:none!important}amp-accordion>section[expanded]>:last-child{display:block!important}
/*# sourceURL=/css/ampshared.css*/</style><meta name=\"next-head-count\" content=\"1\"><meta name=\"viewport\" content=\"width=device-width,minimum-scale=1,initial-scale=1\"><link rel=\"preload\" href=\"https://cdn.ampproject.org/v0.js\" as=\"script\"><script async src=\"https://cdn.ampproject.org/v0.js\"></script><link rel=\"canonical\" href=\"/some-amp?amp=1\"><style amp-custom></style></head><body><!-- __NEXT_DATA__ -->Hi Im an AMP page!</body></html>"

  115 |   it('should have correct canonical link', async () => {
  116 |     const html = await renderViaHTTP(appPort, '/some-amp?amp=1')
> 117 |     expect(html).toMatch(/rel="canonical" href="\/some-amp"/)
      |                  ^
  118 |   })
  119 | 
  120 |   it('should have correct canonical link (auto-export link)', async () => {

  at Object.<anonymous> (integration/serverless/test/index.test.js:117:18)

● Serverless › should have correct canonical link (auto-export link)

expect(received).toMatch(expected)

Expected pattern: /rel="canonical" href="\/some-amp"/
Received string:  "<!DOCTYPE html><html amp i-amphtml-layout i-amphtml-no-boilerplate transformed=\"self;v=1\"><head><meta charset=\"utf-8\"><style amp-runtime i-amphtml-version=\"012002251816300\">html{overflow-x:hidden!important}html.i-amphtml-fie{height:100%!important;width:100%!important}html:not([amp4ads]),html:not([amp4ads]) body{height:auto!important}html:not([amp4ads]) body{margin:0!important}body{-webkit-text-size-adjust:100%;-moz-text-size-adjust:100%;-ms-text-size-adjust:100%;text-size-adjust:100%}html.i-amphtml-singledoc.i-amphtml-embedded{-ms-touch-action:pan-y;touch-action:pan-y}html.i-amphtml-fie>body,html.i-amphtml-singledoc>body{overflow:visible!important}html.i-amphtml-fie:not(.i-amphtml-inabox)>body,html.i-amphtml-singledoc:not(.i-amphtml-inabox)>body{position:relative!important}html.i-amphtml-webview>body{overflow-x:hidden!important;overflow-y:visible!important;min-height:100vh!important}html.i-amphtml-ios-embed-legacy>body{overflow-x:hidden!important;overflow-y:auto!important;position:absolute!important}html.i-amphtml-ios-embed{overflow-y:auto!important;position:static}#i-amphtml-wrapper{overflow-x:hidden!important;overflow-y:auto!important;position:absolute!important;top:0!important;left:0!important;right:0!important;bottom:0!important;margin:0!important;display:block!important}html.i-amphtml-ios-embed.i-amphtml-ios-overscroll,html.i-amphtml-ios-embed.i-amphtml-ios-overscroll>#i-amphtml-wrapper{-webkit-overflow-scrolling:touch!important}#i-amphtml-wrapper>body{position:relative!important;border-top:1px solid transparent!important}#i-amphtml-wrapper+body{visibility:visible}#i-amphtml-wrapper+body .i-amphtml-lightbox-element,#i-amphtml-wrapper+body[i-amphtml-lightbox]{visibility:hidden}#i-amphtml-wrapper+body[i-amphtml-lightbox] .i-amphtml-lightbox-element{visibility:visible}#i-amphtml-wrapper.i-amphtml-scroll-disabled,.i-amphtml-scroll-disabled{overflow-x:hidden!important;overflow-y:hidden!important}amp-instagram{padding:54px 0px 0px!important;background-color:#fff}amp-iframe iframe{box-sizing:border-box!important}[amp-access][amp-access-hide]{display:none}[subscriptions-dialog],body:not(.i-amphtml-subs-ready) [subscriptions-action],body:not(.i-amphtml-subs-ready) [subscriptions-section]{display:none!important}amp-experiment,amp-live-list>[update],amp-share-tracking{display:none}.i-amphtml-jank-meter{position:fixed;background-color:rgba(232,72,95,0.5);bottom:0;right:0;color:#fff;font-size:16px;z-index:1000;padding:5px}amp-list[resizable-children]>.i-amphtml-loading-container.amp-hidden{display:none!important}amp-list[load-more] [load-more-button],amp-list[load-more] [load-more-end],amp-list[load-more] [load-more-failed],amp-list[load-more] [load-more-loading]{display:none}amp-story-page,amp-story[standalone]{min-height:1px!important;display:block!important;height:100%!important;margin:0!important;padding:0!important;overflow:hidden!important;width:100%!important}amp-story[standalone]{background-color:#202125!important;position:relative!important}amp-story-page{background-color:#757575}amp-story .amp-active>div{display:none!important}amp-story-page:not(:first-of-type):not([distance]):not([active]){transform:translateY(1000vh)!important}amp-autocomplete{position:relative!important;display:inline-block!important}amp-autocomplete>input,amp-autocomplete>textarea{padding:0.5rem;border:1px solid rgba(0,0,0,0.33)}.i-amphtml-autocomplete-results,amp-autocomplete>input,amp-autocomplete>textarea{font-size:1rem;line-height:1.5rem}[amp-fx^=fly-in]{visibility:hidden}
/*# sourceURL=/css/ampdoc.css*/[hidden]{display:none!important}.i-amphtml-element{display:inline-block}.i-amphtml-blurry-placeholder{transition:opacity 0.3s cubic-bezier(0.0,0.0,0.2,1)!important}[layout=nodisplay]:not(.i-amphtml-element){display:none!important}.i-amphtml-layout-fixed,[layout=fixed][width][height]:not(.i-amphtml-layout-fixed){display:inline-block;position:relative}.i-amphtml-layout-responsive,[layout=responsive][width][height]:not(.i-amphtml-layout-responsive),[width][height][sizes]:not(.i-amphtml-layout-responsive){display:block;position:relative}.i-amphtml-layout-intrinsic{display:inline-block;position:relative;max-width:100%}.i-amphtml-intrinsic-sizer{max-width:100%;display:block!important}.i-amphtml-layout-container,.i-amphtml-layout-fixed-height,[layout=container],[layout=fixed-height][height]{display:block;position:relative}.i-amphtml-layout-fill,[layout=fill]:not(.i-amphtml-layout-fill){display:block;overflow:hidden!important;position:absolute;top:0;left:0;bottom:0;right:0}.i-amphtml-layout-flex-item,[layout=flex-item]:not(.i-amphtml-layout-flex-item){display:block;position:relative;-ms-flex:1 1 auto;flex:1 1 auto}.i-amphtml-layout-fluid{position:relative}.i-amphtml-layout-size-defined{overflow:hidden!important}.i-amphtml-layout-awaiting-size{position:absolute!important;top:auto!important;bottom:auto!important}i-amphtml-sizer{display:block!important}.i-amphtml-blurry-placeholder,.i-amphtml-fill-content{display:block;height:0;max-height:100%;max-width:100%;min-height:100%;min-width:100%;width:0;margin:auto}.i-amphtml-layout-size-defined .i-amphtml-fill-content{position:absolute;top:0;left:0;bottom:0;right:0}.i-amphtml-layout-intrinsic .i-amphtml-sizer{max-width:100%}.i-amphtml-replaced-content,.i-amphtml-screen-reader{padding:0!important;border:none!important}.i-amphtml-screen-reader{position:fixed!important;top:0px!important;left:0px!important;width:4px!important;height:4px!important;opacity:0!important;overflow:hidden!important;margin:0!important;display:block!important;visibility:visible!important}.i-amphtml-screen-reader~.i-amphtml-screen-reader{left:8px!important}.i-amphtml-screen-reader~.i-amphtml-screen-reader~.i-amphtml-screen-reader{left:12px!important}.i-amphtml-screen-reader~.i-amphtml-screen-reader~.i-amphtml-screen-reader~.i-amphtml-screen-reader{left:16px!important}.i-amphtml-unresolved{position:relative;overflow:hidden!important}.i-amphtml-select-disabled{-webkit-user-select:none!important;-moz-user-select:none!important;-ms-user-select:none!important;user-select:none!important}.i-amphtml-notbuilt,[layout]:not(.i-amphtml-element){position:relative;overflow:hidden!important;color:transparent!important}.i-amphtml-notbuilt:not(.i-amphtml-layout-container)>*,[layout]:not([layout=container]):not(.i-amphtml-element)>*{display:none}.i-amphtml-ghost{visibility:hidden!important}.i-amphtml-element>[placeholder],[layout]:not(.i-amphtml-element)>[placeholder]{display:block}.i-amphtml-element>[placeholder].amp-hidden,.i-amphtml-element>[placeholder].hidden{visibility:hidden}.i-amphtml-element:not(.amp-notsupported)>[fallback],.i-amphtml-layout-container>[placeholder].amp-hidden,.i-amphtml-layout-container>[placeholder].hidden{display:none}.i-amphtml-layout-size-defined>[fallback],.i-amphtml-layout-size-defined>[placeholder]{position:absolute!important;top:0!important;left:0!important;right:0!important;bottom:0!important;z-index:1}.i-amphtml-notbuilt>[placeholder]{display:block!important}.i-amphtml-hidden-by-media-query{display:none!important}.i-amphtml-element-error{background:red!important;color:#fff!important;position:relative!important}.i-amphtml-element-error:before{content:attr(error-message)}i-amp-scroll-container,i-amphtml-scroll-container{position:absolute;top:0;left:0;right:0;bottom:0;display:block}i-amp-scroll-container.amp-active,i-amphtml-scroll-container.amp-active{overflow:auto;-webkit-overflow-scrolling:touch}.i-amphtml-loading-container{display:block!important;pointer-events:none;z-index:1}.i-amphtml-notbuilt>.i-amphtml-loading-container{display:block!important}.i-amphtml-loading-container.amp-hidden{visibility:hidden}.i-amphtml-element>[overflow]{cursor:pointer;position:relative;z-index:2;visibility:hidden}.i-amphtml-element>[overflow].amp-visible{visibility:visible}template{display:none!important}.amp-border-box,.amp-border-box *,.amp-border-box :after,.amp-border-box :before{box-sizing:border-box}amp-pixel{display:none!important}amp-analytics,amp-story-auto-ads{position:fixed!important;top:0!important;width:1px!important;height:1px!important;overflow:hidden!important;visibility:hidden}html.i-amphtml-fie>amp-analytics{position:initial!important}[visible-when-invalid]:not(.visible),amp-list [fetch-error],form [submit-error],form [submit-success],form [submitting]{display:none}amp-accordion{display:block!important}amp-accordion>section{float:none!important}amp-accordion>section>*{float:none!important;display:block!important;overflow:hidden!important;position:relative!important}amp-accordion,amp-accordion>section{margin:0}amp-accordion>section>:last-child{display:none!important}amp-accordion>section[expanded]>:last-child{display:block!important}
/*# sourceURL=/css/ampshared.css*/</style><meta name=\"next-head-count\" content=\"1\"><meta name=\"viewport\" content=\"width=device-width,minimum-scale=1,initial-scale=1\"><link rel=\"preload\" href=\"https://cdn.ampproject.org/v0.js\" as=\"script\"><script async src=\"https://cdn.ampproject.org/v0.js\"></script><link rel=\"canonical\" href=\"/some-amp?amp=1\"><style amp-custom></style></head><body><!-- __NEXT_DATA__ -->Hi Im an AMP page!</body></html>"

  120 |   it('should have correct canonical link (auto-export link)', async () => {
  121 |     const html = await renderViaHTTP(appPort, '/some-amp.amp')
> 122 |     expect(html).toMatch(/rel="canonical" href="\/some-amp"/)
      |                  ^
  123 |   })
  124 | 
  125 |   it('should render correctly when importing isomorphic-unfetch', async () => {

  at Object.<anonymous> (integration/serverless/test/index.test.js:122:18)

test/integration/serverless-trace/test/index.test.js

  • Serverless Trace > should have correct canonical link
  • Serverless Trace > should have correct canonical link (auto-export link)
Expand output

● Serverless Trace › should have correct canonical link

expect(received).toMatch(expected)

Expected pattern: /rel="canonical" href="\/some-amp"/
Received string:  "<!DOCTYPE html><html amp i-amphtml-layout i-amphtml-no-boilerplate transformed=\"self;v=1\"><head><meta charset=\"utf-8\"><style amp-runtime i-amphtml-version=\"012002251816300\">html{overflow-x:hidden!important}html.i-amphtml-fie{height:100%!important;width:100%!important}html:not([amp4ads]),html:not([amp4ads]) body{height:auto!important}html:not([amp4ads]) body{margin:0!important}body{-webkit-text-size-adjust:100%;-moz-text-size-adjust:100%;-ms-text-size-adjust:100%;text-size-adjust:100%}html.i-amphtml-singledoc.i-amphtml-embedded{-ms-touch-action:pan-y;touch-action:pan-y}html.i-amphtml-fie>body,html.i-amphtml-singledoc>body{overflow:visible!important}html.i-amphtml-fie:not(.i-amphtml-inabox)>body,html.i-amphtml-singledoc:not(.i-amphtml-inabox)>body{position:relative!important}html.i-amphtml-webview>body{overflow-x:hidden!important;overflow-y:visible!important;min-height:100vh!important}html.i-amphtml-ios-embed-legacy>body{overflow-x:hidden!important;overflow-y:auto!important;position:absolute!important}html.i-amphtml-ios-embed{overflow-y:auto!important;position:static}#i-amphtml-wrapper{overflow-x:hidden!important;overflow-y:auto!important;position:absolute!important;top:0!important;left:0!important;right:0!important;bottom:0!important;margin:0!important;display:block!important}html.i-amphtml-ios-embed.i-amphtml-ios-overscroll,html.i-amphtml-ios-embed.i-amphtml-ios-overscroll>#i-amphtml-wrapper{-webkit-overflow-scrolling:touch!important}#i-amphtml-wrapper>body{position:relative!important;border-top:1px solid transparent!important}#i-amphtml-wrapper+body{visibility:visible}#i-amphtml-wrapper+body .i-amphtml-lightbox-element,#i-amphtml-wrapper+body[i-amphtml-lightbox]{visibility:hidden}#i-amphtml-wrapper+body[i-amphtml-lightbox] .i-amphtml-lightbox-element{visibility:visible}#i-amphtml-wrapper.i-amphtml-scroll-disabled,.i-amphtml-scroll-disabled{overflow-x:hidden!important;overflow-y:hidden!important}amp-instagram{padding:54px 0px 0px!important;background-color:#fff}amp-iframe iframe{box-sizing:border-box!important}[amp-access][amp-access-hide]{display:none}[subscriptions-dialog],body:not(.i-amphtml-subs-ready) [subscriptions-action],body:not(.i-amphtml-subs-ready) [subscriptions-section]{display:none!important}amp-experiment,amp-live-list>[update],amp-share-tracking{display:none}.i-amphtml-jank-meter{position:fixed;background-color:rgba(232,72,95,0.5);bottom:0;right:0;color:#fff;font-size:16px;z-index:1000;padding:5px}amp-list[resizable-children]>.i-amphtml-loading-container.amp-hidden{display:none!important}amp-list[load-more] [load-more-button],amp-list[load-more] [load-more-end],amp-list[load-more] [load-more-failed],amp-list[load-more] [load-more-loading]{display:none}amp-story-page,amp-story[standalone]{min-height:1px!important;display:block!important;height:100%!important;margin:0!important;padding:0!important;overflow:hidden!important;width:100%!important}amp-story[standalone]{background-color:#202125!important;position:relative!important}amp-story-page{background-color:#757575}amp-story .amp-active>div{display:none!important}amp-story-page:not(:first-of-type):not([distance]):not([active]){transform:translateY(1000vh)!important}amp-autocomplete{position:relative!important;display:inline-block!important}amp-autocomplete>input,amp-autocomplete>textarea{padding:0.5rem;border:1px solid rgba(0,0,0,0.33)}.i-amphtml-autocomplete-results,amp-autocomplete>input,amp-autocomplete>textarea{font-size:1rem;line-height:1.5rem}[amp-fx^=fly-in]{visibility:hidden}
/*# sourceURL=/css/ampdoc.css*/[hidden]{display:none!important}.i-amphtml-element{display:inline-block}.i-amphtml-blurry-placeholder{transition:opacity 0.3s cubic-bezier(0.0,0.0,0.2,1)!important}[layout=nodisplay]:not(.i-amphtml-element){display:none!important}.i-amphtml-layout-fixed,[layout=fixed][width][height]:not(.i-amphtml-layout-fixed){display:inline-block;position:relative}.i-amphtml-layout-responsive,[layout=responsive][width][height]:not(.i-amphtml-layout-responsive),[width][height][sizes]:not(.i-amphtml-layout-responsive){display:block;position:relative}.i-amphtml-layout-intrinsic{display:inline-block;position:relative;max-width:100%}.i-amphtml-intrinsic-sizer{max-width:100%;display:block!important}.i-amphtml-layout-container,.i-amphtml-layout-fixed-height,[layout=container],[layout=fixed-height][height]{display:block;position:relative}.i-amphtml-layout-fill,[layout=fill]:not(.i-amphtml-layout-fill){display:block;overflow:hidden!important;position:absolute;top:0;left:0;bottom:0;right:0}.i-amphtml-layout-flex-item,[layout=flex-item]:not(.i-amphtml-layout-flex-item){display:block;position:relative;-ms-flex:1 1 auto;flex:1 1 auto}.i-amphtml-layout-fluid{position:relative}.i-amphtml-layout-size-defined{overflow:hidden!important}.i-amphtml-layout-awaiting-size{position:absolute!important;top:auto!important;bottom:auto!important}i-amphtml-sizer{display:block!important}.i-amphtml-blurry-placeholder,.i-amphtml-fill-content{display:block;height:0;max-height:100%;max-width:100%;min-height:100%;min-width:100%;width:0;margin:auto}.i-amphtml-layout-size-defined .i-amphtml-fill-content{position:absolute;top:0;left:0;bottom:0;right:0}.i-amphtml-layout-intrinsic .i-amphtml-sizer{max-width:100%}.i-amphtml-replaced-content,.i-amphtml-screen-reader{padding:0!important;border:none!important}.i-amphtml-screen-reader{position:fixed!important;top:0px!important;left:0px!important;width:4px!important;height:4px!important;opacity:0!important;overflow:hidden!important;margin:0!important;display:block!important;visibility:visible!important}.i-amphtml-screen-reader~.i-amphtml-screen-reader{left:8px!important}.i-amphtml-screen-reader~.i-amphtml-screen-reader~.i-amphtml-screen-reader{left:12px!important}.i-amphtml-screen-reader~.i-amphtml-screen-reader~.i-amphtml-screen-reader~.i-amphtml-screen-reader{left:16px!important}.i-amphtml-unresolved{position:relative;overflow:hidden!important}.i-amphtml-select-disabled{-webkit-user-select:none!important;-moz-user-select:none!important;-ms-user-select:none!important;user-select:none!important}.i-amphtml-notbuilt,[layout]:not(.i-amphtml-element){position:relative;overflow:hidden!important;color:transparent!important}.i-amphtml-notbuilt:not(.i-amphtml-layout-container)>*,[layout]:not([layout=container]):not(.i-amphtml-element)>*{display:none}.i-amphtml-ghost{visibility:hidden!important}.i-amphtml-element>[placeholder],[layout]:not(.i-amphtml-element)>[placeholder]{display:block}.i-amphtml-element>[placeholder].amp-hidden,.i-amphtml-element>[placeholder].hidden{visibility:hidden}.i-amphtml-element:not(.amp-notsupported)>[fallback],.i-amphtml-layout-container>[placeholder].amp-hidden,.i-amphtml-layout-container>[placeholder].hidden{display:none}.i-amphtml-layout-size-defined>[fallback],.i-amphtml-layout-size-defined>[placeholder]{position:absolute!important;top:0!important;left:0!important;right:0!important;bottom:0!important;z-index:1}.i-amphtml-notbuilt>[placeholder]{display:block!important}.i-amphtml-hidden-by-media-query{display:none!important}.i-amphtml-element-error{background:red!important;color:#fff!important;position:relative!important}.i-amphtml-element-error:before{content:attr(error-message)}i-amp-scroll-container,i-amphtml-scroll-container{position:absolute;top:0;left:0;right:0;bottom:0;display:block}i-amp-scroll-container.amp-active,i-amphtml-scroll-container.amp-active{overflow:auto;-webkit-overflow-scrolling:touch}.i-amphtml-loading-container{display:block!important;pointer-events:none;z-index:1}.i-amphtml-notbuilt>.i-amphtml-loading-container{display:block!important}.i-amphtml-loading-container.amp-hidden{visibility:hidden}.i-amphtml-element>[overflow]{cursor:pointer;position:relative;z-index:2;visibility:hidden}.i-amphtml-element>[overflow].amp-visible{visibility:visible}template{display:none!important}.amp-border-box,.amp-border-box *,.amp-border-box :after,.amp-border-box :before{box-sizing:border-box}amp-pixel{display:none!important}amp-analytics,amp-story-auto-ads{position:fixed!important;top:0!important;width:1px!important;height:1px!important;overflow:hidden!important;visibility:hidden}html.i-amphtml-fie>amp-analytics{position:initial!important}[visible-when-invalid]:not(.visible),amp-list [fetch-error],form [submit-error],form [submit-success],form [submitting]{display:none}amp-accordion{display:block!important}amp-accordion>section{float:none!important}amp-accordion>section>*{float:none!important;display:block!important;overflow:hidden!important;position:relative!important}amp-accordion,amp-accordion>section{margin:0}amp-accordion>section>:last-child{display:none!important}amp-accordion>section[expanded]>:last-child{display:block!important}
/*# sourceURL=/css/ampshared.css*/</style><meta name=\"next-head-count\" content=\"1\"><meta name=\"viewport\" content=\"width=device-width,minimum-scale=1,initial-scale=1\"><link rel=\"preload\" href=\"https://cdn.ampproject.org/v0.js\" as=\"script\"><script async src=\"https://cdn.ampproject.org/v0.js\"></script><link rel=\"canonical\" href=\"/some-amp?amp=1\"><style amp-custom></style></head><body><!-- __NEXT_DATA__ -->Hi Im an AMP page!</body></html>"

  74 |   it('should have correct canonical link', async () => {
  75 |     const html = await renderViaHTTP(appPort, '/some-amp?amp=1')
> 76 |     expect(html).toMatch(/rel="canonical" href="\/some-amp"/)
     |                  ^
  77 |   })
  78 | 
  79 |   it('should have correct canonical link (auto-export link)', async () => {

  at Object.<anonymous> (integration/serverless-trace/test/index.test.js:76:18)

● Serverless Trace › should have correct canonical link (auto-export link)

expect(received).toMatch(expected)

Expected pattern: /rel="canonical" href="\/some-amp"/
Received string:  "<!DOCTYPE html><html amp i-amphtml-layout i-amphtml-no-boilerplate transformed=\"self;v=1\"><head><meta charset=\"utf-8\"><style amp-runtime i-amphtml-version=\"012002251816300\">html{overflow-x:hidden!important}html.i-amphtml-fie{height:100%!important;width:100%!important}html:not([amp4ads]),html:not([amp4ads]) body{height:auto!important}html:not([amp4ads]) body{margin:0!important}body{-webkit-text-size-adjust:100%;-moz-text-size-adjust:100%;-ms-text-size-adjust:100%;text-size-adjust:100%}html.i-amphtml-singledoc.i-amphtml-embedded{-ms-touch-action:pan-y;touch-action:pan-y}html.i-amphtml-fie>body,html.i-amphtml-singledoc>body{overflow:visible!important}html.i-amphtml-fie:not(.i-amphtml-inabox)>body,html.i-amphtml-singledoc:not(.i-amphtml-inabox)>body{position:relative!important}html.i-amphtml-webview>body{overflow-x:hidden!important;overflow-y:visible!important;min-height:100vh!important}html.i-amphtml-ios-embed-legacy>body{overflow-x:hidden!important;overflow-y:auto!important;position:absolute!important}html.i-amphtml-ios-embed{overflow-y:auto!important;position:static}#i-amphtml-wrapper{overflow-x:hidden!important;overflow-y:auto!important;position:absolute!important;top:0!important;left:0!important;right:0!important;bottom:0!important;margin:0!important;display:block!important}html.i-amphtml-ios-embed.i-amphtml-ios-overscroll,html.i-amphtml-ios-embed.i-amphtml-ios-overscroll>#i-amphtml-wrapper{-webkit-overflow-scrolling:touch!important}#i-amphtml-wrapper>body{position:relative!important;border-top:1px solid transparent!important}#i-amphtml-wrapper+body{visibility:visible}#i-amphtml-wrapper+body .i-amphtml-lightbox-element,#i-amphtml-wrapper+body[i-amphtml-lightbox]{visibility:hidden}#i-amphtml-wrapper+body[i-amphtml-lightbox] .i-amphtml-lightbox-element{visibility:visible}#i-amphtml-wrapper.i-amphtml-scroll-disabled,.i-amphtml-scroll-disabled{overflow-x:hidden!important;overflow-y:hidden!important}amp-instagram{padding:54px 0px 0px!important;background-color:#fff}amp-iframe iframe{box-sizing:border-box!important}[amp-access][amp-access-hide]{display:none}[subscriptions-dialog],body:not(.i-amphtml-subs-ready) [subscriptions-action],body:not(.i-amphtml-subs-ready) [subscriptions-section]{display:none!important}amp-experiment,amp-live-list>[update],amp-share-tracking{display:none}.i-amphtml-jank-meter{position:fixed;background-color:rgba(232,72,95,0.5);bottom:0;right:0;color:#fff;font-size:16px;z-index:1000;padding:5px}amp-list[resizable-children]>.i-amphtml-loading-container.amp-hidden{display:none!important}amp-list[load-more] [load-more-button],amp-list[load-more] [load-more-end],amp-list[load-more] [load-more-failed],amp-list[load-more] [load-more-loading]{display:none}amp-story-page,amp-story[standalone]{min-height:1px!important;display:block!important;height:100%!important;margin:0!important;padding:0!important;overflow:hidden!important;width:100%!important}amp-story[standalone]{background-color:#202125!important;position:relative!important}amp-story-page{background-color:#757575}amp-story .amp-active>div{display:none!important}amp-story-page:not(:first-of-type):not([distance]):not([active]){transform:translateY(1000vh)!important}amp-autocomplete{position:relative!important;display:inline-block!important}amp-autocomplete>input,amp-autocomplete>textarea{padding:0.5rem;border:1px solid rgba(0,0,0,0.33)}.i-amphtml-autocomplete-results,amp-autocomplete>input,amp-autocomplete>textarea{font-size:1rem;line-height:1.5rem}[amp-fx^=fly-in]{visibility:hidden}
/*# sourceURL=/css/ampdoc.css*/[hidden]{display:none!important}.i-amphtml-element{display:inline-block}.i-amphtml-blurry-placeholder{transition:opacity 0.3s cubic-bezier(0.0,0.0,0.2,1)!important}[layout=nodisplay]:not(.i-amphtml-element){display:none!important}.i-amphtml-layout-fixed,[layout=fixed][width][height]:not(.i-amphtml-layout-fixed){display:inline-block;position:relative}.i-amphtml-layout-responsive,[layout=responsive][width][height]:not(.i-amphtml-layout-responsive),[width][height][sizes]:not(.i-amphtml-layout-responsive){display:block;position:relative}.i-amphtml-layout-intrinsic{display:inline-block;position:relative;max-width:100%}.i-amphtml-intrinsic-sizer{max-width:100%;display:block!important}.i-amphtml-layout-container,.i-amphtml-layout-fixed-height,[layout=container],[layout=fixed-height][height]{display:block;position:relative}.i-amphtml-layout-fill,[layout=fill]:not(.i-amphtml-layout-fill){display:block;overflow:hidden!important;position:absolute;top:0;left:0;bottom:0;right:0}.i-amphtml-layout-flex-item,[layout=flex-item]:not(.i-amphtml-layout-flex-item){display:block;position:relative;-ms-flex:1 1 auto;flex:1 1 auto}.i-amphtml-layout-fluid{position:relative}.i-amphtml-layout-size-defined{overflow:hidden!important}.i-amphtml-layout-awaiting-size{position:absolute!important;top:auto!important;bottom:auto!important}i-amphtml-sizer{display:block!important}.i-amphtml-blurry-placeholder,.i-amphtml-fill-content{display:block;height:0;max-height:100%;max-width:100%;min-height:100%;min-width:100%;width:0;margin:auto}.i-amphtml-layout-size-defined .i-amphtml-fill-content{position:absolute;top:0;left:0;bottom:0;right:0}.i-amphtml-layout-intrinsic .i-amphtml-sizer{max-width:100%}.i-amphtml-replaced-content,.i-amphtml-screen-reader{padding:0!important;border:none!important}.i-amphtml-screen-reader{position:fixed!important;top:0px!important;left:0px!important;width:4px!important;height:4px!important;opacity:0!important;overflow:hidden!important;margin:0!important;display:block!important;visibility:visible!important}.i-amphtml-screen-reader~.i-amphtml-screen-reader{left:8px!important}.i-amphtml-screen-reader~.i-amphtml-screen-reader~.i-amphtml-screen-reader{left:12px!important}.i-amphtml-screen-reader~.i-amphtml-screen-reader~.i-amphtml-screen-reader~.i-amphtml-screen-reader{left:16px!important}.i-amphtml-unresolved{position:relative;overflow:hidden!important}.i-amphtml-select-disabled{-webkit-user-select:none!important;-moz-user-select:none!important;-ms-user-select:none!important;user-select:none!important}.i-amphtml-notbuilt,[layout]:not(.i-amphtml-element){position:relative;overflow:hidden!important;color:transparent!important}.i-amphtml-notbuilt:not(.i-amphtml-layout-container)>*,[layout]:not([layout=container]):not(.i-amphtml-element)>*{display:none}.i-amphtml-ghost{visibility:hidden!important}.i-amphtml-element>[placeholder],[layout]:not(.i-amphtml-element)>[placeholder]{display:block}.i-amphtml-element>[placeholder].amp-hidden,.i-amphtml-element>[placeholder].hidden{visibility:hidden}.i-amphtml-element:not(.amp-notsupported)>[fallback],.i-amphtml-layout-container>[placeholder].amp-hidden,.i-amphtml-layout-container>[placeholder].hidden{display:none}.i-amphtml-layout-size-defined>[fallback],.i-amphtml-layout-size-defined>[placeholder]{position:absolute!important;top:0!important;left:0!important;right:0!important;bottom:0!important;z-index:1}.i-amphtml-notbuilt>[placeholder]{display:block!important}.i-amphtml-hidden-by-media-query{display:none!important}.i-amphtml-element-error{background:red!important;color:#fff!important;position:relative!important}.i-amphtml-element-error:before{content:attr(error-message)}i-amp-scroll-container,i-amphtml-scroll-container{position:absolute;top:0;left:0;right:0;bottom:0;display:block}i-amp-scroll-container.amp-active,i-amphtml-scroll-container.amp-active{overflow:auto;-webkit-overflow-scrolling:touch}.i-amphtml-loading-container{display:block!important;pointer-events:none;z-index:1}.i-amphtml-notbuilt>.i-amphtml-loading-container{display:block!important}.i-amphtml-loading-container.amp-hidden{visibility:hidden}.i-amphtml-element>[overflow]{cursor:pointer;position:relative;z-index:2;visibility:hidden}.i-amphtml-element>[overflow].amp-visible{visibility:visible}template{display:none!important}.amp-border-box,.amp-border-box *,.amp-border-box :after,.amp-border-box :before{box-sizing:border-box}amp-pixel{display:none!important}amp-analytics,amp-story-auto-ads{position:fixed!important;top:0!important;width:1px!important;height:1px!important;overflow:hidden!important;visibility:hidden}html.i-amphtml-fie>amp-analytics{position:initial!important}[visible-when-invalid]:not(.visible),amp-list [fetch-error],form [submit-error],form [submit-success],form [submitting]{display:none}amp-accordion{display:block!important}amp-accordion>section{float:none!important}amp-accordion>section>*{float:none!important;display:block!important;overflow:hidden!important;position:relative!important}amp-accordion,amp-accordion>section{margin:0}amp-accordion>section>:last-child{display:none!important}amp-accordion>section[expanded]>:last-child{display:block!important}
/*# sourceURL=/css/ampshared.css*/</style><meta name=\"next-head-count\" content=\"1\"><meta name=\"viewport\" content=\"width=device-width,minimum-scale=1,initial-scale=1\"><link rel=\"preload\" href=\"https://cdn.ampproject.org/v0.js\" as=\"script\"><script async src=\"https://cdn.ampproject.org/v0.js\"></script><link rel=\"canonical\" href=\"/some-amp?amp=1\"><style amp-custom></style></head><body><!-- __NEXT_DATA__ -->Hi Im an AMP page!</body></html>"

  79 |   it('should have correct canonical link (auto-export link)', async () => {
  80 |     const html = await renderViaHTTP(appPort, '/some-amp.amp')
> 81 |     expect(html).toMatch(/rel="canonical" href="\/some-amp"/)
     |                  ^
  82 |   })
  83 | 
  84 |   it('should render correctly when importing isomorphic-unfetch', async () => {

  at Object.<anonymous> (integration/serverless-trace/test/index.test.js:81:18)

@ijjk
Copy link
Member

ijjk commented Mar 10, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 9s 9.3s ⚠️ +320ms
nodeModulesSize 56.5 MB 56.5 MB ⚠️ +1.88 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
index.html gzip 916 B 916 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 914 B 914 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 10s 9.7s -343ms
nodeModulesSize 56.5 MB 56.5 MB ⚠️ +1.88 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_error.js gzip 293 kB 293 kB ⚠️ +64 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 293 kB 293 kB -2 B
link.js gzip 301 kB 301 kB ⚠️ +370 B
routerDirect.js gzip 299 kB 299 kB -114 B
withRouter.js gzip 299 kB 300 kB ⚠️ +142 B
Overall change 1.49 MB 1.49 MB ⚠️ +460 B

@ijjk
Copy link
Member

ijjk commented Mar 16, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 9.9s 10.1s ⚠️ +182ms
nodeModulesSize 54.8 MB 54.8 MB ⚠️ +1.88 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
index.html gzip 916 B 916 B ✓
link.html gzip 926 B 926 B ✓
withRouter.html gzip 913 B 913 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 10.7s 10.6s -108ms
nodeModulesSize 54.8 MB 54.8 MB ⚠️ +1.88 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_error.js gzip 293 kB 293 kB ⚠️ +95 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 293 kB 293 kB ⚠️ +55 B
link.js gzip 301 kB 302 kB ⚠️ +392 B
routerDirect.js gzip 300 kB 300 kB -343 B
withRouter.js gzip 300 kB 300 kB ⚠️ +64 B
Overall change 1.49 MB 1.49 MB ⚠️ +263 B

@yosuke-furukawa yosuke-furukawa mentioned this pull request Mar 16, 2020
Closed
@ijjk
Copy link
Member

ijjk commented Mar 17, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 9.9s 10.1s ⚠️ +235ms
nodeModulesSize 54.8 MB 54.8 MB ⚠️ +1.88 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
index.html gzip 916 B 916 B ✓
link.html gzip 924 B 924 B ✓
withRouter.html gzip 911 B 911 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 11.3s 10.9s -446ms
nodeModulesSize 54.8 MB 54.8 MB ⚠️ +1.88 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_error.js gzip 293 kB 293 kB -16 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 293 kB 294 kB ⚠️ +347 B
link.js gzip 301 kB 301 kB ⚠️ +575 B
routerDirect.js gzip 300 kB 300 kB -169 B
withRouter.js gzip 300 kB 300 kB ⚠️ +145 B
Overall change 1.49 MB 1.49 MB ⚠️ +882 B

sebastianbenz
sebastianbenz approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side!

@sebastianbenz sebastianbenz mentioned this pull request Mar 18, 2020
Open
@ijjk
Copy link
Member

ijjk commented Mar 24, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 8.7s 8.9s ⚠️ +197ms
nodeModulesSize 52.9 MB 52.9 MB ⚠️ +1.88 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.2 kB 56.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
index.html gzip 918 B 918 B ✓
link.html gzip 927 B 927 B ✓
withRouter.html gzip 914 B 914 B ✓
Overall change 2.76 kB 2.76 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
buildDuration 9.6s 9.6s ⚠️ +42ms
nodeModulesSize 52.9 MB 52.9 MB ⚠️ +1.88 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.2 kB 56.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary yosuke-furukawa/next.js feat_add_next_amp_optimizer_options_support Change
_error.js gzip 293 kB 294 kB ⚠️ +541 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 960 B 960 B ✓
index.js gzip 294 kB 293 kB -1.19 kB
link.js gzip 302 kB 301 kB -246 B
routerDirect.js gzip 299 kB 300 kB ⚠️ +530 B
withRouter.js gzip 300 kB 300 kB ⚠️ +187 B
Overall change 1.49 MB 1.49 MB -182 B

@timneutkens timneutkens merged commit aadb31f into vercel:canary Mar 24, 2020
This was referenced Apr 13, 2020
Merged
Closed
This was referenced Apr 22, 2020
Merged
Closed
Open
@PavelK27 PavelK27 mentioned this pull request May 28, 2020
Merged
kodiakhq bot pushed a commit that referenced this pull request May 29, 2020
@PavelK27
Update AMP validation docs (#13525)
ff2a03f 
Updates docs for AMP validation with usage examples for custom validators added in #9191 and `skipValidation` mode added in #10705
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@PavelK27 @rokinsky
Update AMP validation docs (vercel#13525)
5d3d021 
Updates docs for AMP validation with usage examples for custom validators added in vercel#9191 and `skipValidation` mode added in vercel#10705
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sebastianbenz sebastianbenz sebastianbenz approved these changes

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yosuke-furukawa @ijjk @sebastianbenz @timneutkens